Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: override rate limit #873

Merged
merged 10 commits into from
Jul 7, 2022
Merged

feat: override rate limit #873

merged 10 commits into from
Jul 7, 2022

Conversation

devthejo
Copy link
Contributor

@devthejo devthejo commented Jun 24, 2022 •
edited

fix #870

@devthejo devthejo mentioned this pull request Jun 24, 2022
Closed
@devthejo devthejo mentioned this pull request Jun 24, 2022
Closed
revolunet
revolunet reviewed Jun 25, 2022
View reviewed changes
cmd/controller/main.go Outdated Show resolved Hide resolved
revolunet
revolunet reviewed Jun 25, 2022
View reviewed changes
cmd/controller/main.go Outdated Show resolved Hide resolved
@devthejo
Update cmd/controller/main.go
3398ce8 
Co-authored-by: Julien Bouquillon <contact@revolunet.com>
devthejo and others added 3 commits June 27, 2022 11:30
@devthejo
Update cmd/controller/main.go
715f65f 
Co-authored-by: Julien Bouquillon <contact@revolunet.com>
@devthejo
Update helm/sealed-secrets/values.yaml
0a03bf2 
Co-authored-by: Julien Bouquillon <contact@revolunet.com>
@devthejo
Update helm/sealed-secrets/values.yaml
d477fba 
Co-authored-by: Julien Bouquillon <contact@revolunet.com>
@alvneiayu
Copy link
Collaborator

alvneiayu commented Jun 30, 2022 •
edited

hi @devthejo

First of all, thanks a lot for the PR and your help.

The reason of the error that you are reproducing in our tests is that you need to split the patch in two of them. One for the feature included in the controller and the second one for the changes in the chart.

Please, remove the chart charges from this PR and create a new one for the chart changes.

Thanks a lot

Álvaro

@alvneiayu alvneiayu added this to Inbox in Sealed Secrets via automation Jun 30, 2022
@alvneiayu alvneiayu added enhancement backlog Issues/PRs that will be included in the project roadmap labels Jun 30, 2022
@alvneiayu alvneiayu moved this from Inbox to In progress in Sealed Secrets Jun 30, 2022
alemorcuq
alemorcuq requested changes Jun 30, 2022
View reviewed changes
cmd/controller/main.go Outdated Show resolved Hide resolved
@devthejo
Copy link
Contributor Author

hi @devthejo

First of all, thanks a lot for the PR and your help.

The reason of the error that you are reproducing in our tests is that you need to split the patch in two of them. One for the feature included in the controller and the second one for the changes in the chart.

Please, remove the chart charges from this PR and create a new one for the chart changes.

Thanks a lot

Álvaro

Hi @alvneiayu,

Thanks for your attention, got it, I will do that very soon

@devthejo devthejo mentioned this pull request Jun 30, 2022
Merged
@devthejo
Copy link
Contributor Author

@alvneiayu I removed the chart changes from this PR and opened a separated PR for chart here #876

@devthejo devthejo requested a review from alemorcuq June 30, 2022 16:27
alemorcuq
alemorcuq approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@alemorcuq alemorcuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alvneiayu alvneiayu self-requested a review July 7, 2022 16:29
alvneiayu
alvneiayu approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@alvneiayu alvneiayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alemorcuq alemorcuq merged commit 3e70bda into bitnami-labs:main Jul 7, 2022
Sealed Secrets automation moved this from In progress to Completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revolunet revolunet revolunet left review comments

@alvneiayu alvneiayu alvneiayu approved these changes

@alemorcuq alemorcuq alemorcuq approved these changes

Assignees
No one assigned
Labels
backlog Issues/PRs that will be included in the project roadmap enhancement
Projects
Sealed Secrets
  
Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/v1/verify endpoint throttling
4 participants
@devthejo @alvneiayu @revolunet @alemorcuq