Update CI to support Go 1.19 #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alemorcuq
requested review from
alvneiayu,
agarcia-oss and
josvazg
as code owners
josvazg
reviewed
Aug 4, 2022
| @@ -8,16 +8,16 @@ | |||
| // This example will make it possible to set the default of --my_flag also via the MY_PROG_MY_FLAG | |||
| // env var: | |||
| // | |||
| // var myflag = flag.String("my_flag", "", "some flag") | |||
| // var myflag = flag.String("my_flag", "", "some flag") | |||
There was a problem hiding this comment.
Is this a tabs vs spaces thing?
why dd this change?
There was a problem hiding this comment.
This was automatic formatting by goimports, which is one of the linting tools we use. The linting job was failing so I run goimports over the code.
josvazg
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Benefits