Make the controller main skinny #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
josvazg
force-pushed
the
make-controller-main-skinny
branch
from
903c79a
to
caf3115
Compare
agarcia-oss
approved these changes
Sep 8, 2022
This was referenced Sep 22, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The Controller has way too much code within the main package.
The first step to allow easy modularity is to move most code outside of main, where we can further slice it and separate it.
Benefits
Code moves to a package where it is easier to further refactor.