Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme files not updated if relok8s backend used #137

Open
migmartri opened this issue Jan 21, 2022 · 3 comments
Open

Readme files not updated if relok8s backend used #137

migmartri opened this issue Jan 21, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@migmartri
Copy link

If the relocation is performed using relok8s, the readme file change is not performed. Maybe this step should be decoupled from the relocation backend used.

I am considering this a regression since in the project documentation we state that readme file changes will be performed.

cc/ @tompizmor @jotadrilo

@migmartri migmartri added the bug Something isn't working label Jan 21, 2022
@jotadrilo
Copy link
Contributor

How could we run this process in the air-gapped scenario?

@migmartri
Copy link
Author

It's tricky, some additional metadata will be required to be translated next to the relok8s local bundles. This piece of metadata will contain the repoName that will be used in the readme rewrites. Would that make sense?

@jotadrilo
Copy link
Contributor

I would have to take a look at the big picture first. Can you describe which is the charts-syncer -> relok8s behavior? What is modifying the values.yaml files and so on in that case? It feels like the README.md is out of the scope of relok8s but maybe there is no other place to perform additional pre-processing before packaging the charts again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants