Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/keycloak] Support ingress for Keycloak admin area #21712

Closed
dalbani opened this issue Dec 21, 2023 · 11 comments · Fixed by #21872
Closed

[bitnami/keycloak] Support ingress for Keycloak admin area #21712

dalbani opened this issue Dec 21, 2023 · 11 comments · Fixed by #21872
Assignees

Comments

@dalbani
Copy link
Contributor

dalbani commented Dec 21, 2023

Name and Version

bitnami/keycloak

What is the problem this feature will solve?

My deployment of Keycloak on AWS consists of 2 "interfaces":

Combined with the use of KC_HOSTNAME=keycloak.public.company.com, KC_HOSTNAME_ADMIN=keycloak.private.company.com, and setting frontendUrl=https://keycloak.private.company.com on the master realm, I can keep the separation between the public part and private part of my Keycloak deployment.

The problem is that the Bitnami chart supports only a single ingress.
So I had to add a new ingress-2.yaml in my own deployment pipeline, which is more or less a copy of ingress.yaml.
Which is obviously far from ideal in terms of maintenance, code duplication, etc.

What is the feature you are proposing to solve the problem?

I propose to add support for a so-called "admin ingress" to the chart, in addition to the existing one.
In terms of functionality, the admin ingress would be identical to the regular ingress but configurable via values under adminIngress.
What do you think?

In terms of implementation, we could copy ingress.yaml into admin-ingress.yaml, and add the necessary changes in values.yaml.
Or, instead of duplicating ingress.yaml, we could introduce a template that could generate both ingress and adminIngress resources.

@github-actions github-actions bot added the triage Triage is needed label Dec 21, 2023
@carrodher
Copy link
Member

Did you try using the extraDeploy parameter? Maybe that makes the trick for you, see https://github.com/bitnami/charts/tree/main/bitnami/keycloak#deploy-extra-resources

@dalbani
Copy link
Contributor Author

dalbani commented Dec 21, 2023

Thanks for the suggestion, I wasn't aware of this extraDeploy functionality.
I use ArgoCD for the deployment, so adding an additional resource is not really an issue.
It's more that having this (almost identical) copy of ingress.yaml in my codebase is not really optimal.

And I suppose that the dual public/private ingress is not unique to my deployment, isn't it?

@carrodher
Copy link
Member

I don't recall seeing this issue in the past, if you think it's a common scenario, feel free to submit a PR adding the admin-ingress.yaml

Copy link

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label Jan 18, 2024
@dalbani
Copy link
Contributor Author

dalbani commented Jan 18, 2024

Not stale.

@github-actions github-actions bot removed the stale 15 days without activity label Jan 19, 2024
Copy link

github-actions bot commented Feb 4, 2024

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label Feb 4, 2024
@dalbani
Copy link
Contributor Author

dalbani commented Feb 4, 2024

Not stale.

@github-actions github-actions bot removed the stale 15 days without activity label Feb 5, 2024
Copy link

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label Feb 21, 2024
@dalbani
Copy link
Contributor Author

dalbani commented Feb 21, 2024

Unstale.

@github-actions github-actions bot removed the stale 15 days without activity label Feb 22, 2024
@busyboy77
Copy link

I don't think everyone is going to deploy Keycloak using AWS only.

We have been running bitnami/keycloak for last 4 years for on-prem based solutions where only 1 single domain is required.

Now using 2 FQDNS for identity and admin area are strong NOT feasible for our deployment requirements,

@dalbani
Copy link
Contributor Author

dalbani commented Mar 16, 2024

I'm not sure I understand what your point was, @busyboy77.
For the record, you don't have to use the adminIngress, it's just an option offered by the chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants