Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to Chart AppVersion for termination in "common.images.image" #23536

Closed
Ergaac opened this issue Feb 14, 2024 · 3 comments
Closed

Fallback to Chart AppVersion for termination in "common.images.image" #23536

Ergaac opened this issue Feb 14, 2024 · 3 comments
Assignees
Labels
common feature-request solved stale 15 days without activity triage Triage is needed

Comments

@Ergaac
Copy link

Ergaac commented Feb 14, 2024

Name and Version

bitnami/common 2.15.3

What is the problem this feature will solve?

Some best practices say for the image tag to match the Chart AppVersion. This is already the fallback for "common.images.version", but is not implemented in "common.images.image"
https://jfrog.com/blog/helm-charts-best-practices/

image: "{{ .Values.image.repository }}:{{ default .Chart.AppVersion .Values.image.tag }}"

What is the feature you are proposing to solve the problem?

Implement a fallback of $termination to use Chart AppVersion if imageRoot.tag is not supplied.

@github-actions github-actions bot added the triage Triage is needed label Feb 14, 2024
@carrodher
Copy link
Member

Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.

Copy link

github-actions bot commented Mar 1, 2024

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label Mar 1, 2024
Copy link

github-actions bot commented Mar 7, 2024

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

@github-actions github-actions bot added the solved label Mar 7, 2024
@bitnami-bot bitnami-bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common feature-request solved stale 15 days without activity triage Triage is needed
Projects
None yet
Development

No branches or pull requests

3 participants