-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/keycloak] The default value of existingSecretHostKey, existingSecretUserKey, etc is not working #25880
Comments
Hi @xqe2011
Are you referring to the secret-external-db.yaml template? Please note this template will be ignored if
Maybe you're using an old values.yaml? There's no |
No, I am referring to the In |
Hi @xqe2011 So you're suggesting that we use set {{- if and (not .Values.postgresql.enabled) .Values.externalDatabase.existingSecret }} |
Hi @juan131 Yes. This change can reduce the time spent investigating why |
@xqe2011 I've been reviewing the logic and it works like this:
I agree it's over-complicated. Let me review this with the team. |
This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary. |
Name and Version
bitnami/keycloak 21.2.1
What architecture are you using?
amd64
What steps will reproduce the bug?
externalDatabase.existingSecret
in values.yaml to this secret nameAre you using any custom parameters or values?
What is the expected behavior?
The document says
externalDatabase.existingSecret Name of an existing secret resource containing the database credentials
. In my opinion, this secret should contain the username, password, port, host, etc. However, after I review the template, only the password is included.What do you see instead?
The environment variables such as
KEYCLOAK_DATABASE_HOST
aren't generated.Additional information
In values.yaml, it defines
keycloak.databaseSecretHostKey
defaults todb-host
. But inconfigmap-env-vars.yaml
, it uses.Values.externalDatabase.existingSecretHostKey
for testing whether it should generate the env. Maybe it should bekeycloak.databaseSecretHostKey
?If it is an expected behavior, we should add documents describing this, or users will be confused as to why my secret doesn't take effect
The text was updated successfully, but these errors were encountered: