This repository has been archived by the owner on Feb 9, 2022. It is now read-only.
docs: friends don't let friends editorialize the quickstart guides #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falfaro
suggested changes
Oct 24, 2018
| @@ -1,30 +1,37 @@ | |||
| # Quickstart: BKPR on Azure Kubernetes Service (AKS) | |||
There was a problem hiding this comment.
Can we rename this to AKS Quickstart to be consistent with the README.md document that links here?
There was a problem hiding this comment.
I am not too keen on changing the title.
I would like to know what @arapulido and @anguslees thinks about this.
sameersbn
commented
Oct 24, 2018
| az ad app delete \ | ||
| --subscription ${AZURE_SUBSCRIPTION_ID} \ | ||
| --id $(jq -r .oauthProxy.client_id kubeprod-autogen.json) | ||
| ``` |
There was a problem hiding this comment.
@anguslees @falfaro I've added these commands to clean up the app registrations. Ideally we should adding a kubeprod reset command to automatically clean up these things.
falfaro
approved these changes
Oct 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.