Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

Minor update in GKE quick start #264

Merged
merged 4 commits into from
Dec 7, 2018
Merged

Conversation

migmartri
Copy link
Contributor

No description provided.

@falfaro
Copy link
Contributor

falfaro commented Dec 5, 2018

LGTM!

@anguslees
Copy link
Contributor

anguslees commented Dec 6, 2018

The original description for that value is:

 `GCLOUD_USER` specifies the email address used in requests to Let's Encrypt.

I agree it has the same default value in the instructions, and the name "GCLOUD_USER" sounds like it should always have that value. This description however sounds like it should be a personal/antispam email address, which may not be the same as your GCP username.

TL;DR: For a quickstart, I think it's fine to reuse the GCP auth email for the letsencrypt contact. I suggest we change the description for GCLOUD_USER to be "the email address used to authenticate to Google Cloud Platform."

@sameersbn
Copy link
Contributor

Thanks for the contribution @migmartri. Like @anguslees pointed out the two email addresses are not necessarily always the same. In the current iteration of the doc, GCLOUD_USER configures the Let's encrypt contact email address that's used in lets encrypt requests (i agree it's a poorly named variable 🙂). Whereas while creating the clusterrolebinding, as Gus pointed out, we have to specify the email address used to authenticate to Google Cloud Platform.

Could you also update the description of the GCLOUD_USER field as suggested by Gus and also update the default value of GCLOUD_USER to $(gcloud info --format='value(config.account)')

@migmartri
Copy link
Contributor Author

Just updated it, but I am a little bit confused TBH.

The email flag provided during installation is the email address for lets encrypt then? https://github.com/bitnami/kube-prod-runtime/pull/264/files#diff-d9eaa84d62d91998f096c8ff57ace5e2L117

and also update the default value of GCLOUD_USER to $(gcloud info --format='value(config.account)')

This is already the case isn't it?

Thanks!

@sameersbn
Copy link
Contributor

The email flag provided during installation is the email address for lets encrypt then?

This is right. We're using the email address only for the lets encrypt setup. But I would not say that it's future use would be limited to just that. We would be using it in any setup that requires the cluster administrators email.

This is already the case isn't it?

Oh yes, that's right!

@sameersbn sameersbn merged commit 0c5f1f8 into master Dec 7, 2018
@sameersbn sameersbn deleted the minor-update-in-GKE-quick-start branch December 7, 2018 05:41
@migmartri
Copy link
Contributor Author

Thanks for confirming it @sameersbn!

dbarranco pushed a commit that referenced this pull request Dec 13, 2018
* Minor update in GKE quick start

* Update description
dbarranco added a commit that referenced this pull request Dec 13, 2018
* Add Prometheus migration guide

* Changing image and cleaning docs

* Add feedback - Still WIP

* Add more feedback

* Add more feedback

* Add information about Kubecfg

* Add vikram suggestions

* Add image of a failed TSDB migration

* Rewording

* Update docs/migration-guides/prometheus-migration.md

Co-Authored-By: dbarranco <dbarranco@bitnami.com>

* Update docs/migration-guides/prometheus-migration.md

Co-Authored-By: dbarranco <dbarranco@bitnami.com>

* Update docs/migration-guides/prometheus-migration.md

Co-Authored-By: dbarranco <dbarranco@bitnami.com>

* Update docs/migration-guides/prometheus-migration.md

Co-Authored-By: dbarranco <dbarranco@bitnami.com>

* Apply suggestions from code review

Co-Authored-By: dbarranco <dbarranco@bitnami.com>

* Fix Grafana datasource configuration and volume mountpoint location (#260)

* Better explanation on failure to set IAM policy for GKE. (#258)

* Better explanation on failure to set IAM policy for GKE.

* Better error message.

* Minor update in GKE quick start (#264)

* Minor update in GKE quick start

* Update description

* Adds a troubleshooting guide (#263)

* first step in the creation of a troubleshooting guide

Signed-off-by: Sameer Naik <sameer@bitnami.com>

* Object with the same value for property exists

Closes #242

Signed-off-by: Sameer Naik <sameer@bitnami.com>

* fix indentation

* fixes tagging releases on github (#265)

Bug in the publishing caused every release to be tagged as a
pre-release.

Signed-off-by: Sameer Naik <sameer@bitnami.com>

* docs: add quickstart section back to the readme (#266)

* fixed typo (#267)

* docs: guide to deploy Kubeapps using Helm (#262)

* docs: guide to deploy Kubeapps using Helm

Signed-off-by: Sameer Naik <sameer@bitnami.com>

* Update docs/kubeapps-on-bkpr.md

Co-Authored-By: sameersbn <sameer@damagehead.com>

* Update docs/kubeapps-on-bkpr.md

Co-Authored-By: sameersbn <sameer@damagehead.com>

* address review comments

* Update docs/kubeapps-on-bkpr.md

Co-Authored-By: sameersbn <sameer@damagehead.com>

* address review comments

Signed-off-by: Sameer Naik <sameer@bitnami.com>

* install tiller securely

Signed-off-by: Sameer Naik <sameer@bitnami.com>

* link to kubeapps guides

* suggest kubeapps installation in quickstart guides

Signed-off-by: Sameer Naik <sameer@bitnami.com>

* fix minor typo in gke-quickstart

* address extended review

* gke seems to have removed support for k8s 1.9 (#271)

Signed-off-by: Sameer Naik <sameer@bitnami.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants