Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download page: JQuery options need "inactive" class #8

Closed
tomgreever opened this issue Apr 9, 2013 · 5 comments
Closed

Download page: JQuery options need "inactive" class #8

tomgreever opened this issue Apr 9, 2013 · 5 comments

Comments

@tomgreever
Copy link
Contributor

the last two plugins on the DL page require JQuery, so we need to add a class="inactive" to the s for those if a user selects a different library. Same on the homepage downloader.

@daffl
Copy link
Contributor

daffl commented Apr 10, 2013

👍 - Maybe we should grey out the entire line that's affected?

@tomgreever
Copy link
Contributor Author

Yes, that's why it should be applied to the tr... Sorry, github removed my "tr" tag in my comment

@dispatchrabbi
Copy link
Contributor

I'll commit the version that adds class=inactive to the tr's on the download page. It also adds class=inactive to the li's on the hero downloader. Right now they don't do anything; Tom can you change that please?

tomgreever added a commit that referenced this issue Apr 18, 2013
Signed-off-by: Tom Greever <anybody@tomgreever.com>
@tomgreever
Copy link
Contributor Author

This works on the homepage now, doesn't seem to be implemented on the download page tho

@dispatchrabbi
Copy link
Contributor

Should be working on both, and that's what my working version confirms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants