Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete documentation for can.List.prototype.filter #1165

Closed
jawshooah opened this issue Jul 14, 2014 · 3 comments
Closed

Incomplete documentation for can.List.prototype.filter #1165

jawshooah opened this issue Jul 14, 2014 · 3 comments
Milestone

Comments

@jawshooah
Copy link

It probably bears mentioning in the docs that the prototype method filter of can.Map.List overrides that of can.List, and does not take a second argument thisArg as the method in can.List does.

@jawshooah
Copy link
Author

For that matter, there's no mention at all of can.Map.List.prototype.map in the docs.

@justinbmeyer justinbmeyer added this to the 2.1.3 milestone Jul 23, 2014
@andykant andykant self-assigned this Jul 25, 2014
@andykant
Copy link
Contributor

I'll take a look at this, I believe there is also some vagueness in that some of this filter/sort support in Lists is via plugins when it isn't specified in the documentation as such.

@andykant
Copy link
Contributor

I added documentation for the can/map/list plugin. Is does indeed change the function signature for List.filter, so I added that information to the documentation as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants