Dispatch correct arguments with can.List:splice if inserting and removing the same elements.

[justinbmeyer]

Related to: 0b7b107

Something like this should break:

var list = new can.List(["a","b"]);
list.bind("remove", function(ev, items, index){
  equal(items.length, 2);
});
list.splice(0,2,"a","b");

Also, splice is checking every item removed against every item added. n^2 when it should be n.

cc @brianmoschel

[moschel]

@BigAB did you fix this directly in Master? We always fix stuff like that in a branch, add a test to prove its fixed, and only merge after someone has given it a +1.

[moschel]

Oh you did add a test :) But it went directly into master. Can you please close this if all tests are passing and the issue is fixed?

[BigAB]

I did make a branch and a pull request #1278

There is a test

Justin merged it +1 and merged it.

Yes I will close this issue.