Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing bound scope properties on destroy #1415

Closed
moschel opened this issue Jan 23, 2015 · 4 comments
Closed

removing bound scope properties on destroy #1415

moschel opened this issue Jan 23, 2015 · 4 comments
Labels
Milestone

Comments

@moschel
Copy link
Contributor

moschel commented Jan 23, 2015

By the time the destroy event of a component is run, the bound scope properties are no longer bound to their parent component properties. In other words, if you pass a cross bind a scope property from a parent to child component like:

<my-component product="{product}"></my-component>

Then you want to clean up that product reference while the component is destroyed like:

events: {
  destroyed: function(){
    this.scope.attr('product', null);
  }
}

This won't throw an error, but the product property of the parent component won't be affected by this, because the property bindings are unbound before destroyed is called. I think we should change the order so the bindings are cleaned up after destroyed is called.

@moschel
Copy link
Contributor Author

moschel commented Feb 9, 2015

@daffl can't we close this?

@daffl
Copy link
Contributor

daffl commented Feb 9, 2015

No. Referenced issues will be closed automatically once in master.

@justinbmeyer
Copy link
Contributor

We can close them before that if they are in minor. Too bad github doesn't have some setting like this.

@daffl
Copy link
Contributor

daffl commented Feb 10, 2015

We could make minor the default branch. I don't think that finding all the still open but referenced issues in merged PRs against minor is necessary though. I'd also rather have people watching an issue be notified if a new release has been made not just if the fix made it in a development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants