can.Observe.prototype.each overrides {{#each}} Mustache helper. #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I'm assuming that helper should always have priority right? |
|
I bet the specification has something to say about this. If not, I'm not sure the helper would have higher priority. It might be more expensive to change a bunch of item's property names than to alias a helper. |
|
https://github.com/wycats/handlebars.js/blob/master/spec/qunit_spec.js#L1019 |
daffl
added a commit
that referenced
this pull request
Mar 25, 2013
can.Observe.prototype.each overrides {{#each}} Mustache helper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Mustache.get (can/view/mustache/mustache.js line 822 in current HEAD) prototype functions and data members of the context object override Mustache helpers. This causes the "each" helper to be unavailable when using a can.Observe, since its prototype includes "each", and an exception is thrown due to the two functions having different type signatures.