can.route.pushstate mishandles hash fragments

[talentedmrjones]

For links containing hash fragments like

<a href="/articles/17#references">

The URL gets set to /articles/17%23references and window.location.hash == ''

[justinbmeyer]

Can you create a fiddle showing this because I'm not understanding what you mean exactly.

Sent from my iPhone

On Jan 28, 2013, at 9:55 AM, Richard Jones notifications@github.com wrote:

For links containing hash fragments like

The URL gets set to /articles/17%23references and window.location.hash == ''

—
Reply to this email directly or view it on GitHub.

[talentedmrjones]

I take that back. I'm sorry the hash symbol being URL encoded was from a change I made to the core of the plugin.

Look here:https://github.com/bitovi/canjs/blob/master/route/pushstate/pushstate.js#L42

You will see this.pathname+this.search

window.location.hash is not included at all. Therefore the pushstate code does not allow for links that contain hashes. I'd like to use pushstate but also need to support hashes so I can jump to specific places in the page based on window.location.hash.

I've tried changing that line to this.pathname+this.hash+this.search but that ended up URL encoding the # and left window.location.hash empty.