adding greedy space to model url splitter #284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am migrating a JMVC app over to CanJS and encountered strange DOM Exception 12 errors on model CRUD events. It took me a while to chase them down and discovered that the splitter employed in CanJS was failing to properly spit on my URLs because I used multiple spaces. I like all my routes to line up "just so" for better readability:
JMVC handled these routes okay.
This little fix just makes the splitter greedier to handle the extra spaces.