Don't treat links to "#" as "/"

[DVSoftware]

Breaks many places where "#" is placed as a dummy href and are handled through click events. It can be prevented with stopPropagation() but then it won't propagate to its parents. This fixes my case, but i'm not sure if it's desirable for others.

[justinbmeyer]

You should not have dummy links with #, javascript:// is better but still wrong.

Prevent changing the hash with preventDefault()

On Feb 17, 2013, at 12:55 PM, DVSoftware notifications@github.com wrote:

Breaks many places where "#" is placed as a dummy href and are handled through click events. It can be prevented with stopPropagation() but then it won't propagate to its parents. This fixes my case, but i'm not sure if it's desirable for others.

You can merge this Pull Request by running

git pull https://github.com/DVSoftware/canjs patch-1
Or view, comment on, or merge it at:

#285

Commit Summary

Don't treat links to "#" as "/"
File Changes

M route/pushstate/pushstate.js (18)
Patch Links:

https://github.com/bitovi/canjs/pull/285.patch
https://github.com/bitovi/canjs/pull/285.diff

[DVSoftware]

But it still catches them, unless i call stopPropagation(), which in my case breaks catching the outerclicks (i listen to clicks on body, to close modal windows etc), as it doesn't propagate further. I could change to "javascript://" but i kinda still think it's wrong to treat "#" as "/" route (at least with pushstate).

[justinbmeyer]

What do you mean catches them? The route will change unless preventDefault is called, not stopPropagation.

It's not wrong to respond to changing the hash to #. If the hash changes, can.route should respond to it, whatever it is. Otherwise back button and bookmarking won't work as expected.

On Feb 17, 2013, at 1:18 PM, DVSoftware notifications@github.com wrote:

But it still catches them, unless i call stopPropagation(), which in my case breaks catching the outerclicks (i listen to clicks on body, to close modal windows etc), as it doesn't propagate further. I could change to "javascript://" but i kinda still think it's wrong to treat "#" as "/" route (at least with pushstate).

—
Reply to this email directly or view it on GitHub.

[DVSoftware]

Well, the thing is, it does change even if preventDefault is called. At
least it's the case with pushstate, i'm not sure about hashchange as i
don't use it.
18.02.2013. 00.26, "Justin Meyer" notifications@github.com је написао/ла:

What do you mean catches them? The route will change unless preventDefault
is called, not stopPropagation.

It's not wrong to respond to changing the hash to #. If the hash changes,
can.route should respond to it, whatever it is. Otherwise back button and
bookmarking won't work as expected.

On Feb 17, 2013, at 1:18 PM, DVSoftware notifications@github.com wrote:

But it still catches them, unless i call stopPropagation(), which in my
case breaks catching the outerclicks (i listen to clicks on body, to close
modal windows etc), as it doesn't propagate further. I could change to
"javascript://" but i kinda still think it's wrong to treat "#" as "/"
route (at least with pushstate).

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/285#issuecomment-13700179.

[DVSoftware]

This should do it, instead of checking for '#', i now changed it to check if default is prevented.

[justinbmeyer]

THis looks good.

[DVSoftware]

Travis build seems to be stalled for some reason, going to the link says it's actually passed...