Add VERSION property to CanJS Object #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wasn't sure what we wanted to do about the VERSION property when using CanJS from GitHub. The version will be Alternatively, we could just update this property manually in the source, but I would prefer to automate as much as possible. |
|
Changed the default value to |
| { | ||
| pattern: /@EDGE/gim, //version property | ||
| replacement: '<%= pkg.version %>' | ||
| }, |
There was a problem hiding this comment.
Can you remove the tailing comma? I guess it's one of my pet peeves but it shows up as an error in Webstorm and any JS linter.
daffl
added a commit
that referenced
this pull request
Apr 26, 2013
Add VERSION property to CanJS Object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For detecting what version is loaded.
What about adding this to
can.js:The grunt build scripts would have to be updated to keep this in synch with the version in
package.json