1.1.6pre - something going wrong with can.computes() in Mustache templates #376
Comments
|
Example code/test? Sent from my iPhone On May 2, 2013, at 6:03 AM, SteveEisner notifications@github.com wrote:
|
|
@justinbmeyer Sorry, I built a fiddle but I can't get it to repro. http://jsfiddle.net/G34Vf/2/ So instead I'm attaching a souce & stack example of the break from my production code. I realize that a non-executing example may not be that helpful, but this might at least give you an idea? In the topmost frame, I'm inside a can.compute and "this" is global/window. In the bottom frame, I'm setting an attr of a can.Observe which has been rendered through a mustache template. I've confirmed that the same code runs just fine if I switch to 1.1.5 ... I don't think I'm doing anything out of the ordinary, but I have hit other boundary cases before with the same code [issue #218] Source//=== template (person.mustache) ======
{{#model}}
..... {{name}} ..... <-- name is the can.compute
{{/model}}
//=== top frame (person.js) =====
Person = Model({
// No class methods
},{
name: can.compute(function() {
var first = this.attr('first'); <-- line 7, where the error is in the stack below
*** Uncaught TypeError: Object [object global] has no method 'attr' ***
var last = this.attr('last');
if (!first) return last;
if (!last) return first;
return first + ' ' + last;
})
});
//=== bottom frame (frame.js) =====
...
setModel: function(model) {
this.attrs.attr({ model: model }); <--- attrs is the Observe instance that was rendered
return model;
}
....StackOnly the top and bottom frames are user code, the rest are can JS modules, generated template code, or jquery. |
|
I went looking for other similar bugs and found #305 -- which happens to be exactly the same model I'm trying to create. When I first made these models, I guess I thought that for a function to work in a mustache rendering, it had to be a can.compute (based on examples?) But I've confirmed that my code works with 1.1.6 now if I simply remove the can.compute() and make the "name" method a simple function. |
|
You shouldn't do it that way. Closing this issue. |
|
No need to write out a detailed description in a bug, but I'm curious if you have a link that explains why one shouldn't do it that way -- I got the pattern from a canjs team member's code at: https://forum.javascriptmvc.com/topic/can-compute-crazies If I want to be able to observe the "name" attribute, how should I build the model instead? |
|
#305 shows how |
|
Thanks! On Tue, May 7, 2013 at 9:41 AM, Justin Meyer notifications@github.comwrote:
|
Just an FYI since the "1.1.6pre" has been pushed to "latest" on the CDN.
In this version only (same code confirmed working when I switch back to 1.1.5) when rendering a model via mustache template, if I reference a can.compute property via {{name}} the context passed into the compute is the global window, rather than the model... Any compute that is trying to use "this" will break.
The text was updated successfully, but these errors were encountered: