-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong variable name in the Guide. #431
Comments
It looks like the wiki is not open for public editing. I've made these changes on my fork but apparently we can't make a pull request for a wiki. Is it possible to open the wiki for public editing? |
Yes. I can't edit the Wiki yet. And Github is not support Wiki pulling as well. |
I think we will fix this soon. Thanks for pointing it out. |
How can this be fixed? Is opening the wiki for public editing an acceptable solution? |
I'm still not sure how to solve this best. I wouldn't mind making it publicly editable (question is: how to do quality assurance before publishing it to the website?). We were also thinking about simply moving the guides into the CanJS main repository where the API documentation is already coming from which can be edited using PRs. |
What about moving the guides to the canjs.com repo? |
On this page: http://canjs.com/guides/EJS.html This code: Should be document.getElementById('todos').appendChild(frag); |
After a discussion with @justinbmeyer I think we are just going to put the guides in the main repository so that they can be updated with a pull request. |
http://canjs.com/guides/Observes.html
Section 'Converted Computes'.
Line 3. var progressPercentage
It should be 'var percentage'.
http://canjs.com/guides/Routing.html
Section 'If you give can.route a template, you can make pretty URLs:'.
Line 12. window.location.hash; // '#!users/7'
'#!users/7' should be '#!users/29'.
Have a nice day.
The text was updated successfully, but these errors were encountered: