Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong variable name in the Guide. #431

Closed
dorajistyle opened this issue Jun 14, 2013 · 9 comments
Closed

Wrong variable name in the Guide. #431

dorajistyle opened this issue Jun 14, 2013 · 9 comments

Comments

@dorajistyle
Copy link

http://canjs.com/guides/Observes.html

Section 'Converted Computes'.

Line 3. var progressPercentage

It should be 'var percentage'.

http://canjs.com/guides/Routing.html

Section 'If you give can.route a template, you can make pretty URLs:'.

Line 12. window.location.hash; // '#!users/7'

'#!users/7' should be '#!users/29'.

Have a nice day.

@daffl
Copy link
Contributor

daffl commented Jun 14, 2013

Thanks! You should be able to edit this guide in the Wiki (observes, routing). When we deploy the page again it should get updated. I'm also working on getting edit links on each page so that you can go there directly.

@codr
Copy link

codr commented Jul 22, 2013

It looks like the wiki is not open for public editing. I've made these changes on my fork but apparently we can't make a pull request for a wiki.

Is it possible to open the wiki for public editing?

@dorajistyle
Copy link
Author

Yes. I can't edit the Wiki yet. And Github is not support Wiki pulling as well.

@justinbmeyer
Copy link
Contributor

I think we will fix this soon. Thanks for pointing it out.

@codr
Copy link

codr commented Jul 25, 2013

How can this be fixed? Is opening the wiki for public editing an acceptable solution?

@daffl
Copy link
Contributor

daffl commented Jul 25, 2013

I'm still not sure how to solve this best. I wouldn't mind making it publicly editable (question is: how to do quality assurance before publishing it to the website?).

We were also thinking about simply moving the guides into the CanJS main repository where the API documentation is already coming from which can be edited using PRs.

@codr
Copy link

codr commented Jul 25, 2013

What about moving the guides to the canjs.com repo?
It does seems a little weird to have a wiki with a bunch of @ tags in it.

@norm-mp
Copy link

norm-mp commented Aug 9, 2013

On this page: http://canjs.com/guides/EJS.html

This code:
can.view('todosAndUser', {
todos: Todo.findAll(),
user: User.findOne({id: 5})
}).then(function(frag) {
document.getElementById('todos').appendChild(fragment);
});

Should be document.getElementById('todos').appendChild(frag);

@daffl
Copy link
Contributor

daffl commented Oct 11, 2013

After a discussion with @justinbmeyer I think we are just going to put the guides in the main repository so that they can be updated with a pull request.

@daffl daffl closed this as completed Oct 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants