Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourceURL comment in Scanner.prototype.scan() cause error on IE8 #679

Closed
pYr0x opened this issue Jan 18, 2014 · 3 comments · Fixed by #784
Closed

sourceURL comment in Scanner.prototype.scan() cause error on IE8 #679

pYr0x opened this issue Jan 18, 2014 · 3 comments · Fixed by #784
Milestone

Comments

@pYr0x
Copy link

pYr0x commented Jan 18, 2014

an easy sample:

var overviewRenderer = can.view(Config.baseUrl+'/js/templates/overview.mustache'); 

will cause an error on IE8 on this line

myEval.call(out, 'this.fn = (function(' + this.text.argNames + '){' + out.out + '});\r\n//@ sourceURL=' + name + ".js");

the problem is //@ sourceURL=' + name + ".js" if i remove the comment the script works fine.

see #108

@justinbmeyer
Copy link
Contributor

AFAIK this only breaks with conditional comments turned on or some other strange thing. But it does not break in IE8 with only canjs and jQuery.

We have looked into why this breaks and how to feature detect it with no luck.

Cc @imjoshdean

Sent from my iPhone

On Jan 18, 2014, at 10:50 AM, pYr0x notifications@github.com wrote:

an easy sample:

var overviewRenderer = can.view(Config.baseUrl+'/js/templates/overview.mustache');
will cause an error on IE8 on this line

myEval.call(out, 'this.fn = (function(' + this.text.argNames + '){' + out.out + '});\r\n//@ sourceURL=' + name + ".js");
the problem is //@ sourceURL=' + name + ".js" if i remove the comment the script works fine.


Reply to this email directly or view it on GitHub.

@justinbmeyer
Copy link
Contributor

It was this bug: #108 cc @dispatchrabbi

@pYr0x pYr0x closed this as completed Jan 18, 2014
@pYr0x pYr0x reopened this Jan 18, 2014
@pYr0x
Copy link
Author

pYr0x commented Jan 18, 2014

these guys had the same problem... maybe they have solved it?
lodash/lodash#49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants