Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can.Components ignores attributes containing "id" #693

Closed
wclr opened this issue Jan 23, 2014 · 1 comment
Closed

can.Components ignores attributes containing "id" #693

wclr opened this issue Jan 23, 2014 · 1 comment
Labels
Milestone

Comments

@wclr
Copy link
Contributor

wclr commented Jan 23, 2014

can.Component ignores wrong attributes:

var ignoreAttributesRegExp = /dataViewId|class|id/i

this:

ignoreAttributesRegExp.test(name)

will be true for all names that contain "id" letters inside (as well "class").

this will do the work

/^(dataViewId|class|id)$/i
@justinbmeyer justinbmeyer added this to the 2.1.0 milestone Feb 7, 2014
@daffl
Copy link
Contributor

daffl commented Feb 10, 2014

Fixed via 4815551

@daffl daffl closed this as completed Feb 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants