can.Mustache: using local helpers inside partials

[isadovskiy]

I tried to use local helpers (defined via can.view("#template", data, helpers)) inside partial. However partial did not find the helper.

Inside mustache.js I see the following code:

// Call into `can.view.render` passing the
// partial and scope.
return can.view.render(partial, scope /*, options*/ );

"Options" are commented for some reason. Uncommenting this piece makes helpers available inside partials. So is there any specific reason why it's commented and if uncommenting this line could cause ant issues?

[isadovskiy]

Any feedback on this issue?

[justinbmeyer]

Try uncommenting it and seeing if our tests pass.

[isadovskiy]

For some reason tests does not work for me...

Running "qunit:steal" (qunit) task
Testing http://localhost:8000/test/jquery.html
Warning: PhantomJS timed out, possibly due to a missing QUnit start() call. Use --force to continue.

Aborted due to warnings.

Tests are lunched. I even can open test page in browser. But suddenly it interrupts by timeout...

[daffl]

What operating system are you using?

[isadovskiy]

Win7

[daffl]

From what I could find out so far, PhantomJS (which doesn't need to be installed btw, grunt-qunit uses the NPM package) runs a little slower on Windows.
I got the tests to start by setting the timeout in https://github.com/bitovi/canjs/blob/master/Gruntfile.js#L218 higher (to e.g. 60000):

But now it sometimes hangs when running a different test. This might be solved when migrating from the Grunt QUnit task to Testee which I am planning to do (it didn't stall when I tried it at least).

I will look into it some more but if it keeps stalling for you, too, to develop CanJS and write tests, the workaround would be just running grunt build and then run all the test files (test/index.html and maybe test/dist/jquery.html) in the browser and let Travis do the automated testing when making a pull request.

[isadovskiy]

I extended timeout to 60,000 ms. It gave time to pass http://localhost:8000/test/jquery.html test in browser:

Tests completed in 25489 milliseconds.
1959 assertions of 1959 passed, 0 failed.

BTW, as for development/contribution to CanJS - do you have any instructions (rules to create branches for fixes, pull requests and etc)?

[isadovskiy]

I re-compiled the code with uncommented /, options/ param and run the tests in browser. Both test/jquery.html and test/dist/jquery.html worked out fine for me, without errors.

[matthewp]

@isadovskiy Here's the contributing guide.

[isadovskiy]

To submit a fix, should I create a branch in original canjs repository or in own forked repository?

[matthewp]

Fork.

[isadovskiy]

Thanks for the clarification, Matthew.