Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can.list.sort triggers event before sorting but none after #828

Closed
vlork opened this issue Mar 26, 2014 · 2 comments
Closed

can.list.sort triggers event before sorting but none after #828

vlork opened this issue Mar 26, 2014 · 2 comments
Milestone
2.2.0

Comments

@vlork
Copy link

vlork commented Mar 26, 2014

Suggestion:
https://github.com/initialize/canjs/commit/2c1ef1faf24df959a948338be8daf2939f1f02bd

(Sorry, I'm kinda new to github. Is this the right way to suggest changes?)
@vlork
Copy link
Author

vlork commented Mar 26, 2014

Also, it would be nice if it would trigger a 'reset' event after sorting has been done when pushing objects to the array.

@akagomez akagomez mentioned this issue Feb 18, 2015
Merged
@daffl daffl modified the milestone: 2.2.0 Feb 18, 2015
@daffl
Copy link
Contributor

daffl commented Feb 19, 2015

This has been fixed via #1454

@daffl daffl closed this as completed Feb 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@daffl @vlork