add/remove events always give you back arrays #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can.List add event should always be an array Don't trigger remove events on shift/pop for 0-length lists For add events, include leading undefineds in the 'added' array
|
Would this be a 3.0 change? I know it's not tested anywhere but wouldn't this break all code that's listening to an |
|
We document add always getting an array. Our code was broken. This is a bug fix. |
daffl
added a commit
that referenced
this pull request
Feb 10, 2015
add/remove events always give you back arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can.List add event should always be an array
Don't trigger remove events on shift/pop for 0-length lists
For add events, include leading undefineds in the 'added' array
Fixes #998