Feature/route to string

[schovi]

It is almost same pull request as #272 but the second one is from master branch, what is completely wrong (i have never done pull request before :) )

I improve the stringifiing part of this feature and add test for this. It is used in our current project for more than 2 weeks and it looks fine and working.

[daffl]

One request: Would it be possible to disable the auto code formatting? It's kind of hard to tell what actually changed if the diff shows all the tabs and spaces that got modified. I'll run everything through a beautifier for 1.2 so that things will be more consistent.

[schovi]

@daffl Reverted commit, hope it is fine now.

[schovi]

Had some issue with merging canjs master into this branch.
If this is problem, or there is lot of commits i can recreate it into only new one.

[daffl]

Yes, sorry didn't have a chance to really look at this. Could you maybe also explain the reason for the string conversion a little more? I can see from the tests where this is going but am not sure why it would be necessary. Thanks!

[schovi]

I noticed this as problem in my app, where i keep current state of page in hash params. Most of them are key - value where value is integer (id of something).
I think this is pretty common usecase and it works fine until

1. I use strict comparsion (for example in view)

<% something.each(function(smth) { %>
    <div class="<% can.route.attr('something_id') === smth.id ? "active" : "" %>" <%= (el) -> el.data('smth', smth) %>>
        <%= smth.name %>
    </div>
<% }) %>

Then in control

{
    init: function() {},
    "div.click": function(el, ev) {
        can.route.attr('something_id', el.data('smth').id)
    },
    "{can.route} something_id": function(route, ev, what, somethingId) {
        if(somethingId) {
            $.ajax('something/' + somethingId)
        }
    }
}

So this is usecase. When i have app in zero state and click on something div it sets something_id = 1 (integer) in can.route.
It trigger binding, div will be active and some ajax call is started.
It is perfect.

But what happend when i do refresh with something_id parameter sets.
It parses route and sets parameters into can.route. In this case something_id = "1" (string). It triggers and call ajax request, but div wont be active because I compare it with 1 (integer) via ===
Now I can click on something div (with same id) and something_id = 1 (integer) is set on can.route. Div is mark as active and SECOND ajax call is called.

[justinbmeyer]

This is a good idea. We should review this and get it in for 1.2

[imjoshdean]

Couldn't merge, but implemented your suggestion, worked like a charm. Closing up on this.

[schovi]

Good to hear guys .)
Where can i find the commit?

[imjoshdean]

@schovi It's on our dev branch and will make it's way to the 1.2/2.0 release of CanJS.

Commit is here: b363ee9