can.Model.model attribute serialization fix #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That makes sense. Can you add a test and somehow reference the original issue (something like "closes #444" in the commit message should do it). Thanks. |
Instead of checking instanceof, just check if it's something with a serialize function attached to it. This allows can.Model.model to accept can.Observe (and anything else that's "serializable"). This does have the side-effect that "serialize" becomes a reserved property, but there's other parts of canjs where this happens, such as can.Observe#bind Fixes #444
daffl
added a commit
that referenced
this pull request
Jul 18, 2013
can.Model.model attribute serialization fix
|
👍 - Woot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking instanceof, just check if it's something with a
serialize function attached to it. This allows can.Model.model to
accept can.Observe (and anything else that's "serializable").
This does have the side-effect that "serialize" becomes a reserved
property, but there's other parts of canjs where this happens, such as
can.Observe#bind
This should fix #444.