can.route.ready called multiple times

[ccummings]

can.route.ready is being called twice (or more if the user calls it themselves) which calls setState and binds to the hashChange event each time.

can.route.ready is the handler for the ready event (L503) and is then called on L508. This results in 2 bindings to the hashChange event (more if user calls can.route.ready themselves).

The other issue is that any modifications to the route before the ready event are wiped out by one of the other setState calls.

I've added a flag that only allows ready to be called once.

[ccummings]

I realized my first attempt at a fix was pretty ham fisted so I've changed it to have a lighter touch.

If you are using jQuery, it will fire a ready event so we don't need to also check the readyState of the DOM. This new fix allows a user to call can.route.ready as much as they want, but it will only be called once on page load.

[daffl]

We can get that into 1.1.8 I do however still think that we never should call can.route.ready automatically for 1.2. There is so much confusion around when to use it and when not that it will be a lot easier to explain one way of doing things (if you want to start routing call can.route.read(true)).

[ccummings]

+1
Absolutely agree that ready should have to be called explicitly. I'll create a new issue for that.

[justinbmeyer]

I don't think there is going to be a 1.8. So this is probably not worth bringing in.