When using certain html-comments, can.view.Scanner does not recognize them correctly #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….view.Scanner (by being recognized as tags instead of comments)
…ts (namely all comments, that don’t have a space/tab/newline after the starting `<!—`) as tags instead of comments and therefore try to bind them (which breaks other bindings)
daffl
added a commit
that referenced
this pull request
Dec 9, 2013
When using certain html-comments, can.view.Scanner does not recognize them correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using some html-comments (namely all comments, that don’t have a
space/tab/newlineafter the starting<!—), can.view.Scanner incorrectly recognize them as tags instead of comments and therefore tries to bind them (which breaks other bindings).This pull request contains a breaking test for the problem as well as a proposed fix.
Note: The fix will have a negative impact on overall-performance, though I find it too small to measure how much exactly (I just ran the mustache-tests with and without the fix, didn't make a difference that could not have been cause by normal variation).