Fixing the test for pushstate #652 #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevenvachon Yeah, it was still randomly failing even at 1500ms (not often, but it happens). Difficult to replicate unfortunately, so I'm hoping this fixes it. |
|
Sorry about that. Wish I'd thought of that multiple timeout idea. I think it will fix it. |
|
No worries, honest mistake. That method I used is a good general hack for those types of tests. Not pretty but it works. :) |
andykant
added a commit
that referenced
this pull request
Jan 22, 2014
Fixing the test for pushstate #652
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for pushstate #652 would occasionally fail due to timing issues, this should ensure that it doesn't run into the issue of the window not being ready.