Fix for calling removeAttr with number type (on lists) #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -641,7 +641,7 @@ steal('can/util', 'can/util/bind', 'can/construct', 'can/util/batch', function ( | |||
| if (parts.length && current) { | |||
| return current.removeAttr(parts); | |||
| } else { | |||
| if (!!~attr.indexOf('.')) { | |||
| if (typeof attr === 'string' && !!~attr.indexOf('.')) { | |||
There was a problem hiding this comment.
Could we maybe just do if( ('' + attr).indexOf('.') ) {?
There was a problem hiding this comment.
That would have a different effect than his code. A number like 1.2 would then pass (which may be ok).
There was a problem hiding this comment.
Oh good point, I forgot about floating point numbers. I think this works then.
|
Thanks for the fix @janza. It will be going out in 2.1 so I had to create a new PR against minor instead of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made sure attr is string when calling indexOf
Added test for can.list removeAttr method with number argument.