Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding tests for can.route.map #979

Merged
merged 1 commit into from May 16, 2014
Merged

adding tests for can.route.map #979

merged 1 commit into from May 16, 2014

Conversation

moschel
Copy link
Contributor

@moschel moschel commented May 9, 2014

Adding some can.route.map tests that verify two requirements, which I wasn't sure if they were working, and they are:

  1. if the appState map has properties that clash with the URL, the URL should take precedence
  2. after can.route.ready() URL params should populate appState, and appState params that are not in the URL get added

@ccummings ccummings added this to the 2.1.1 milestone May 9, 2014
ccummings pushed a commit that referenced this pull request May 16, 2014
Merge pull request #979 from bitovi/route-tests
ba08a64 
adding tests for can.route.map
@ccummings ccummings merged commit ba08a64 into master May 16, 2014
@ccummings ccummings deleted the route-tests branch May 16, 2014 05:54
@justinbmeyer justinbmeyer mentioned this pull request Dec 28, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moschel @ccummings