expose abort() method on Model calls (if exists) #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but we'll need to add a test before we can pull this. |
added 2 commits
September 4, 2012 18:44
jQuery 1.8 now returns a new promise from .then()
|
Tested. Good thing too; jQuery 1.8 changed the semantics of then(). |
| d.abort = function() { | ||
| return def.abort(); | ||
| }; | ||
| } | ||
| return d; |
There was a problem hiding this comment.
Ideally this would return a promise (with abort() tacked on) instead of a Deferred, but that broke a lot of tests.
imjoshdean
added a commit
that referenced
this pull request
Nov 6, 2012
expose abort() method on Model calls (if exists)
|
Had to revert the pull due to breaking test "store ajax binding" and in general returning the appropriate models. Please fix and submit a new pull request. |
imjoshdean
added a commit
that referenced
this pull request
Nov 13, 2012
WearyMonkey
pushed a commit
to WearyMonkey/canjs
that referenced
this pull request
Dec 31, 2012
Fix a typo in the documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.