Add Chrome Headless support #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrejewski
force-pushed
the
chrome-headless
branch
from
dbcd643
to
c44bd2f
Compare
andrejewski
force-pushed
the
chrome-headless
branch
from
3bf0d43
to
96d3b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a lot of build kicking, I cannot get Firefox passing on Linux. This is because to test Chrome Headless we need to be running the
trustybuild in Travis, which is the only build that supports thechromeadd-on option. Firefox consistently hangs in Trusty for versions38.4.0esr,50.0.2,51.0, and52.2.1esr(aka all version that we use and usually work). The version38.4.0esris what Precise uses so we tried the exact same version and got different results. Nothing in this PR changes Firefox functionality, so I feel confident in merging this feature and delegating the work of making Firefox work on Travis to issue #86.