New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up CI #1

Closed

phillipskevin opened this issue May 13, 2022 · 1 comment · Fixed by #9

Assignees

Contributor

phillipskevin commented May 13, 2022 •

edited

Loading

When you make a PR, it should run linting and unit tests based on a GitHub action

michael-dean-haynie self-assigned this

michael-dean-haynie added a commit that referenced this issue


          #1: set up ci workflow in github actions

8c1979a

michael-dean-haynie mentioned this issue

#1: set up ci workflow in github actions #5

Closed

Contributor Author

phillipskevin commented May 18, 2022

A couple improvements I think we should make:

run the lint/test after PRs are merged to main as well as what is happening now
rename the CI Workflow to Tests so the badge is a little cleaner
add a badge to the README
use the ?branch=main param on the badge (this won't work without number 1 above), but right now if you put in a PR with breaking tests, the badge will show CI as failing

michael-dean-haynie added a commit that referenced this issue


          #1: update readme with status badge for ci tests and linting

48a8ce0

michael-dean-haynie mentioned this issue

Feature/1 set up ci #9

Merged

phillipskevin closed this as completed in #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment