Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/10 support ibm style filtering #14

Merged
merged 18 commits into from
Jun 3, 2022
Merged

Feature/10 support ibm style filtering #14

merged 18 commits into from
Jun 3, 2022

Conversation

michael-dean-haynie
Copy link
Collaborator

  • Added IBM-style filter parsing
  • Refactored MongoDB-style filter parsing so that output is same for both styles
  • Tons of tests 馃憤
  • Re-organized and formatted (prettier)

Readme still needs more info about filter styles and how to use the output.
I want to add that along with the ORM examples to avoid as much re-work as possible.

@michael-dean-haynie
#10: update docs, add config/types for better intellisense
e53620a
@michael-dean-haynie
gh-10: refactor the mongodb style filter
41a14b3 
Now uses "json-logic"-like syntax for output
@michael-dean-haynie
gh-10: add more tests, add compound filters
ba97f5c
@michael-dean-haynie
gh-10: extract MongoValueType enum/logic
eb4b6ee
@michael-dean-haynie
gh-10: re-organize mongo-filter and realted logic
80c0a59
@michael-dean-haynie
gh-10: clean up parse-mongo-filter, add docs
68ec1ab
@michael-dean-haynie
gh-10: first pass parsing ibm-style filters
11e52c6
@michael-dean-haynie
gh-10: add tests for ibm-filtering
7b96fce
@michael-dean-haynie
gh-10: add basic ibm-filter error handling / tests
a82d062
@michael-dean-haynie
gh-10: plug new filtering style modules into lib
09159ce
@michael-dean-haynie
gh-10: fix tests for new filter styles
948bd7f
@michael-dean-haynie
gh-10: update mongo filter to use # attribute refs
faf98ca
@michael-dean-haynie
gh-10: test filter styles have equivalent output
92d8265
@michael-dean-haynie
gh-10: rename helpers, re-organize filter parsers
4adf31d
@michael-dean-haynie
gh-10: use revealing module pattern for exports
99561b1
@michael-dean-haynie
gh-10: install and apply prettier formatting
33d087b
@michael-dean-haynie
gh-10: update readme with minimal filter style info
5d18327
@michael-dean-haynie
Copy link
Collaborator Author

I'm looking in to test failures.

@michael-dean-haynie
gh-10: replace .at() method for custom peek func
3873daf 
Node does not support Array.prototype.at() until v16.6.0
@michael-dean-haynie
Copy link
Collaborator Author

michael-dean-haynie commented Jun 1, 2022 •
edited
Loading

Fixed CI test failures.
Failures on 12.x and 14.x node versions were due to Array.prototype.at() usage, which isn't supported by node until v16.6.0.

Not that it would solve this problem, but I think we should probably update the CI to use 14.x, 16.x and 18.x versions which are currently in use. I'll add an issue for that.

@michael-dean-haynie michael-dean-haynie merged commit 338967f into main Jun 3, 2022
@michael-dean-haynie michael-dean-haynie mentioned this pull request Jun 4, 2022
Closed
@michael-dean-haynie michael-dean-haynie deleted the feature/10-support-ibm-style-filtering branch June 10, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoyAyo RoyAyo RoyAyo approved these changes

@phillipskevin phillipskevin Awaiting requested review from phillipskevin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michael-dean-haynie @RoyAyo