Feature/13 add structured errors #15

michael-dean-haynie · 2022-06-03T00:22:11Z

Replaced vanilla Errors with a custom QuerystringParsingError that has more helpful metadata.
Updated implementations where needed
Updated tests to more closely match one another across the project

closes #13

- add high level sanity tests - cover empty string scenarios

michael-dean-haynie added 4 commits June 1, 2022 19:06

gh-13: add structured error, update tests for page

256e879

gh-13: update tests for parseSort

369fb3e

gh-13: update parseFields and parseInclude tests

a38e214

gh-13: update filter tests with structured errors

1dbbe6d

michael-dean-haynie requested review from phillipskevin and RoyAyo June 3, 2022 00:22

michael-dean-haynie marked this pull request as draft June 3, 2022 00:22

michael-dean-haynie changed the title ~~Draft: Feature/13 add structured errors~~ Feature/13 add structured errors Jun 3, 2022

michael-dean-haynie changed the base branch from feature/10-support-ibm-style-filtering to main June 3, 2022 17:46

michael-dean-haynie marked this pull request as ready for review June 3, 2022 17:46

michael-dean-haynie added 2 commits June 3, 2022 21:13

gh-13: address todos

8c3453c

- add high level sanity tests - cover empty string scenarios

gh-13: fix linting errors (unneeded imports)

a38e7a0

michael-dean-haynie merged commit e25aa5e into main Jun 10, 2022

michael-dean-haynie deleted the feature/13-add-structured-errors branch June 10, 2022 16:37

Provide feedback