HATCH-329: Implement ilike/like array support #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoledgreene
changed the title
roy-coder
reviewed
Aug 29, 2023
| let qsParams; | ||
|
|
||
| // check for like or ilike array as parsing should look different | ||
| const regex = new RegExp(/(\[\$like\]=\[|\[\$ilike\]=\[)/g); |
There was a problem hiding this comment.
This function is already quite long, can we try exporting the new logic into a separate testable function?
roy-coder
reviewed
Aug 29, 2023
| // Handle like/ilike for array of strings | ||
| else if ( | ||
| (key === Operator.LIKE || key === Operator.ILIKE) && | ||
| filters[key].length > 2 |
There was a problem hiding this comment.
added a comment for this. lmk if you still have questions
roy-coder
reviewed
Aug 29, 2023
| const splitQuerystring = querystring.split(iLikeLikeRegExp); | ||
| const objectKey = splitQuerystring[0].concat(splitQuerystring[1]); | ||
|
|
||
| const arraySplitRegex = new RegExp(/(=)/g); |
There was a problem hiding this comment.
I hope we can change it in a way that qs.parse gets the array for us. Something with the %20 spaces looks off to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.