Skip to content

Commit

Permalink
fix(all): added required parameters to certain cordova.exec functions
Browse files Browse the repository at this point in the history
Added a blank array parameter to certain cordova.exec functions to satisfy the exec function
requirements and prevent array.length undefined javascript error.
  • Loading branch information
willhay committed Jul 27, 2016
1 parent beb47c7 commit 69fe4e6
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions www/QRScanner.js
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,10 @@ function doneCallback(callback, clear) {

var QRScanner = {
prepare: function(callback) {
cordova.exec(successCallback(callback), errorCallback(callback), 'QRScanner', 'prepare');
cordova.exec(successCallback(callback), errorCallback(callback), 'QRScanner', 'prepare', []);
},
destroy: function(callback) {
cordova.exec(doneCallback(callback, true), null, 'QRScanner', 'destroy');
cordova.exec(doneCallback(callback, true), null, 'QRScanner', 'destroy', []);
},
scan: function(callback) {
if (!callback) {
Expand All @@ -163,28 +163,28 @@ var QRScanner = {
var success = function(result) {
callback(null, result);
};
cordova.exec(success, errorCallback(callback), 'QRScanner', 'scan');
cordova.exec(success, errorCallback(callback), 'QRScanner', 'scan', []);
},
cancelScan: function(callback) {
cordova.exec(doneCallback(callback), null, 'QRScanner', 'cancelScan');
cordova.exec(doneCallback(callback), null, 'QRScanner', 'cancelScan', []);
},
show: function(callback) {
cordova.exec(doneCallback(callback, true), null, 'QRScanner', 'show');
cordova.exec(doneCallback(callback, true), null, 'QRScanner', 'show', []);
},
hide: function(callback) {
cordova.exec(doneCallback(callback, true), null, 'QRScanner', 'hide');
cordova.exec(doneCallback(callback, true), null, 'QRScanner', 'hide', []);
},
pausePreview: function(callback) {
cordova.exec(doneCallback(callback), null, 'QRScanner', 'pausePreview');
cordova.exec(doneCallback(callback), null, 'QRScanner', 'pausePreview', []);
},
resumePreview: function(callback) {
cordova.exec(doneCallback(callback), null, 'QRScanner', 'resumePreview');
cordova.exec(doneCallback(callback), null, 'QRScanner', 'resumePreview', []);
},
enableLight: function(callback) {
cordova.exec(successCallback(callback), errorCallback(callback), 'QRScanner', 'enableLight');
cordova.exec(successCallback(callback), errorCallback(callback), 'QRScanner', 'enableLight', []);
},
disableLight: function(callback) {
cordova.exec(successCallback(callback), errorCallback(callback), 'QRScanner', 'disableLight');
cordova.exec(successCallback(callback), errorCallback(callback), 'QRScanner', 'disableLight', []);
},
useCamera: function(index, callback) {
cordova.exec(successCallback(callback), errorCallback(callback), 'QRScanner', 'useCamera', [index]);
Expand All @@ -207,16 +207,16 @@ var QRScanner = {
},
openSettings: function(callback) {
if (callback) {
cordova.exec(successCallback(callback), errorCallback(callback), 'QRScanner', 'openSettings');
cordova.exec(successCallback(callback), errorCallback(callback), 'QRScanner', 'openSettings', []);
} else {
cordova.exec(null, null, 'QRScanner', 'openSettings');
cordova.exec(null, null, 'QRScanner', 'openSettings', []);
}
},
getStatus: function(callback) {
if (!callback) {
throw new Error('No callback provided to getStatus method.');
}
cordova.exec(doneCallback(callback), null, 'QRScanner', 'getStatus');
cordova.exec(doneCallback(callback), null, 'QRScanner', 'getStatus', []);
}
};

Expand Down

0 comments on commit 69fe4e6

Please sign in to comment.