Fix: make getBackupCandidate more safe

bitpoke · May 10, 2019 · 9ce4e68 · 9ce4e68
1 parent df08155
commit 9ce4e68
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pkg/controller/mysqlbackup/internal/syncer/job.go b/pkg/controller/mysqlbackup/internal/syncer/job.go
@@ -96,14 +96,14 @@ func (s *jobSyncer) getBackupCandidate() string {
 		replicating := s.cluster.GetNodeCondition(node.Name, api.NodeConditionReplicating)
 		lagged := s.cluster.GetNodeCondition(node.Name, api.NodeConditionLagged)
 
-		isMaster := master.Status == core.ConditionTrue
-		isReplicating := replicating != nil && replicating.Status == core.ConditionTrue
-		isLagged := lagged != nil && lagged.Status == core.ConditionTrue
-
 		if master == nil || replicating == nil || lagged == nil {
 			continue
 		}
 
+		isMaster := master.Status == core.ConditionTrue
+		isReplicating := replicating.Status == core.ConditionTrue
+		isLagged := lagged.Status == core.ConditionTrue
+
 		// select a node that is not master is replicating and is not lagged
 		if !isMaster && isReplicating && !isLagged {
 			return node.Name