Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore pages and Article Viewing #8

Closed
bryanwong8 opened this issue May 22, 2020 · 0 comments
Closed

Explore pages and Article Viewing #8

bryanwong8 opened this issue May 22, 2020 · 0 comments
Labels
frontend This is a frontend issue wontfix This will not be worked on
Projects
Milestone

Comments

@bryanwong8
Copy link
Contributor

bryanwong8 commented May 22, 2020

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Figma Design

Article Display

Screen Shot 2020-05-21 at 4 56 32 PM

User Info Card

Screen Shot 2020-05-28 at 4 14 33 PM

  • This component already exists. This is the components/global/UserInfoCard.tsx file.
  • You should use the {{APIURL}}/api/profiles/{{USERNAME}} route to get information regarding the user for the user info card.

User Articles

Screen Shot 2020-05-28 at 4 14 39 PM

  • This component also already exists (It just needs to be merged into staging). EDIT It has been merged. It is called UserArticleCard in components/article/UserArticleCard.tsx
  • You should call the {{APIURL}}/api/articles?author={{USERNAME}} route to get articles based on the author
  • This should display 5 articles from the user if they have any

Like and bookmark

Screen Shot 2020-05-28 at 4 25 37 PM

  • Both of the emojis should be on the left sidebar of the article. You should be using twitter's emoji library and twitter's emoji. https://www.npmjs.com/package/react-twemoji and https://emojipedia.org/twitter/.
  • When the heart is clicked on, it should be calling the Article favorite route, {{APIURL}}/api/articles/{{slug}}/favorite if the heart is not pressed. Else call the unfavorite route, {{APIURL}}/api/articles/{{slug}}/favorite.
  • Should invert the colors as well
  • When the tag emoji is clicked on, it should call the Article Bookmark route, {{APIURL}}/api/articles/{{slug}}/bookmark and invert the color.
  • This logic already exists in the components/article/ArticlePreview.tsx file for likes. I would recommend copy the logic and alter it for bookmarks as well

Article Body

Screen Shot 2020-05-28 at 4 15 02 PM

  • In the file, there is this variable, const { article }: Article = fetchedArticle || initialArticle; which you can use to get information regarding the article. I would recommend using Postman to visualize the data you are using.
@project-bot project-bot bot added this to To do in Bit Project May 22, 2020
@bryanwong8 bryanwong8 added the frontend This is a frontend issue label May 22, 2020
@bryanwong8 bryanwong8 mentioned this issue May 22, 2020
1 task
@bryanwong8 bryanwong8 removed this from To do in Bit Project May 28, 2020
@bryanwong8 bryanwong8 added this to To do in Dev Team via automation May 28, 2020
@bryanwong8 bryanwong8 added this to the Week 2 milestone May 28, 2020
mzp0625 added a commit to mzp0625/bit-next that referenced this issue May 31, 2020
mzp0625 added a commit to mzp0625/bit-next that referenced this issue May 31, 2020
@mzp0625 mzp0625 mentioned this issue May 31, 2020
2 tasks
Dev Team automation moved this from To do to Done Jun 9, 2020
@bryanwong8 bryanwong8 added the wontfix This will not be worked on label Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This is a frontend issue wontfix This will not be worked on
Projects
Dev Team
  
Done
Development

No branches or pull requests

2 participants