Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FromDayToNight-CreatingInteractiveColorPalettesWithJavaScript #240

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

emily-gui
Copy link
Contributor

@emily-gui emily-gui commented Jun 26, 2020

Reference to issue

Description of the changes proposed in the pull request

  • finished blog

Link to Code SandBox

  • link

Link to Loom video (if blog/workshop completed)

Reviewers requested:

Copy link
Contributor

@atuljayaram atuljayaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great job with the blog! I think you're good to go.


Congrats on adding an interactive color component to your Tiny City!

Throughout this tutorial, we created and designed buttons in JavaScript, and learned how to stylize and link features to these buttons in HTML and CSS.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thanks for reviewing my blog!

Copy link

@alliebailey alliebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so good! I barely made any edits, just a few technical things and a few comments on editing sentences a bit. Once you complete those this should be done!

@@ -0,0 +1,394 @@
# From Day to Night - Creating Interactive Color Palettes with JavaScript

Now that you have completed setting up your Tiny City in HTML and CSS, have you ever wondered what your Tiny City would look like at night? Let's create a day-to-night color palette change by adding interactive buttons with JavaScript! JavaScript is a programming language that allows web developers to add interactive designs to websites, such as buttons, pop-up windows, and so on.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You say interactive here twice, I would change "adding interactive buttons" to just "adding buttons" since you say interactive designs later!

...
```

To prepare for our planned color changes, we shall assign an `id` attribute for each element that is involved, and this allows these elements to be stylized in CSS and manipulate in JavaScript.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"shall" seems a little formal for this blog, I would say "we should" or "we need to"

...
```

By setting the `position` attribute to `relative`, this will allow us to adjust the location of the buttons from its "normal" position, which is the center of the webpage, using the `top` and `right` attributes—the values that we inputted will move buttons to the area below our sun. We will also set the buttons' color to white using the `background-color` attribute.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from their normal position?

...
```

For all the border properties to show up, the `border-style` attribute first must be set. Above, we set our buttons' borders to `solid` that will result in a solid colored border. Feel free to experiment with different kinds of borders from this [CSS Border Styles list](https://www.w3schools.com/css/css_border.asp). As for the additional border attributes, `border-width` and`border-color` adjust the border's thickness and color, respectively, and `border-radius` adjusts the roundness of the corners of the border—this particular property allows up to four values, each value accessing each corner of the element.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the border—this particular property" — for these dashes, you need a space on either side — like this! (please change this for all the big dashes that act like this one. You don't use spaces when you are using these smaller-sized dashes to connect to words)

...
```

Since we already established the `moon` element for our planned color palette change, we should also choose the color we want to our night sky.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"... the color we want" our night sky to be? It sounds a little off the way you've said it


Congrats on adding an interactive color component to your Tiny City!

Throughout this tutorial, we created and designed buttons in JavaScript, and learned how to stylize and link features to these buttons in HTML and CSS.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a little more to the conclusion — even just a sentence. Options include further implementations of what you learned, other features that they can try to add on their own, why these skills are useful in the real world, etc. This helps wrap things up a little more!

@emily-gui
Copy link
Contributor Author

@alliebailey Thank you so much for the helpful feedback! :)
I finished revising my blog to your requests, and I also made a few additional edits, such as changing the wording and replacing the last photo with a gif. Please let me know if any further revisions are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants