Add options to customize selector logic #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efined, --with-inherited
| @@ -20,6 +20,18 @@ def private(obj): | |||
|
|
|||
| class SpecSelector(nose.selector.Selector): | |||
| def __init__(self, *args, **kwargs): | |||
| self._with_inherited = kwargs.has_key("spec_with_inherited") and kwargs["spec_with_inherited"] | |||
There was a problem hiding this comment.
Is there a reason these are all doing has_key + value obtain + del, and not simply self._xxx = kwargs.pop("spec_xxx", False)?
There was a problem hiding this comment.
You're right, now the code is much simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some new options to support a use case mentioned in this question:
--with-inherited - allows to run inherited methods as tests
--with-undefined - allows to run methods that was not defined in the class, but was added later
--with-tools-decorators - lets
istest,nottestdecorators contribute to selector logic--with-tools-decorators-only - runs only those functions and methods that was decorated with
istest(a class containing a method should also be decorated)