Skip to content
This repository has been archived by the owner on Sep 12, 2020. It is now read-only.

Fix FSF address #8

Merged
merged 1 commit into from Feb 25, 2012
Merged

Fix FSF address #8

merged 1 commit into from Feb 25, 2012

Conversation

silas
Copy link
Contributor

@silas silas commented Feb 25, 2012

I maintain Fabric in Fedora and as such I need to get ssh packaged and into the repos.

One of the requirements is reporting certain rpmlint issues upstream.

This patch applies to:

$ rpmlint -I incorrect-fsf-address
incorrect-fsf-address:
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

Which is reported as:

$ rpmlint python-ssh-1.7.13-1.fc16.noarch.rpm 
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/agent.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/channel.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/config.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/sftp.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/sftp_file.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/win_pageant.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/ssh_exception.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/client.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/buffered_pipe.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/compress.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/common.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/ber.py
python-ssh.noarch: E: incorrect-fsf-address /usr/share/doc/python-ssh-1.7.13/LICENSE
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/sftp_client.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/hostkeys.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/dsskey.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/pipe.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/file.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/transport.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/kex_group1.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/primes.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/util.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/message.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/sftp_server.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/sftp_handle.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/kex_gex.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/rsakey.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/logging22.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/__init__.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/auth_handler.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/sftp_si.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/server.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/sftp_attr.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/resource.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/packet.py
python-ssh.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/ssh/pkey.py
1 packages and 0 specfiles checked; 36 errors, 0 warnings.

@bitprophet
Copy link
Owner

That's amusing, I wonder when they moved. I'd almost guarantee the address in this source code has been untouched since Robey first set everything up years back :) Thanks for letting us know about this, I'll merge soon.

EDIT: Right, I can actually use the Web merge here, there's no other host. (My other big project is still technically self hosted so I have no "merge button" habit..)

bitprophet added a commit that referenced this pull request Feb 25, 2012
@bitprophet bitprophet merged commit a23803f into bitprophet:master Feb 25, 2012
@silas
Copy link
Contributor Author

silas commented Feb 25, 2012

Cool, thanks for merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants