Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

NDK updated to r14 #46

Merged
merged 1 commit into from
Mar 21, 2017
Merged

NDK updated to r14 #46

merged 1 commit into from
Mar 21, 2017

Conversation

koral--
Copy link
Contributor

@koral-- koral-- commented Mar 15, 2017

No description provided.

@viktorbenei
Copy link
Contributor

viktorbenei commented Mar 16, 2017

The error is:

Step 6 : RUN cd /opt/android-ndk-tmp && unzip -q android-ndk-r14-linux-x86_64.zip
 ---> Running in 5813f6818827
ApplyLayer exit status 1 stdout:  stderr: write /opt/android-ndk-tmp/android-ndk-r14/toolchains/llvm/prebuilt/linux-x86_64/lib64/clang/3.8/lib/linux/libclang_rt.asan-i686.a: no space left on device

Did the size of NDK grow significantly since 13?

In any case, thank you for the PR and we'll try to check why there's not enough space for the new NDK ASAP

@koral--
Copy link
Contributor Author

koral-- commented Mar 16, 2017

Yes, it grown:

root@30f4cd06dfc0:/bitrise/src# du -hcs android-ndk-r13b
2.4G	android-ndk-r13b
2.4G	total
root@30f4cd06dfc0:/bitrise/src# du -hcs /opt/android-ndk/
2.8G	/opt/android-ndk/
2.8G	total

@viktorbenei
Copy link
Contributor

Thanks @koral-- !

We'll try to review this and push it through ASAP, but it most likely won't be a part of this weekend's update, only next week's - the update images are created in less than 24 hours, so that we can run tests with them on Friday (and fix anything if required) before the deploy on Saturday.

@viktorbenei
Copy link
Contributor

We increased storage/disk space on the Linux/Android stack, re-run of the PR was successful with the increased storage.

Schedule: We'll merge this PR next week, and will be part of next weekend's updates!

@viktorbenei
Copy link
Contributor

Perfect, re-build success and all tests passed - will be part of this weekend's updates. Thanks again for the PR @koral-- ! ;)

@viktorbenei viktorbenei merged commit 3865c07 into bitrise-io:master Mar 21, 2017
@jfirebaugh
Copy link

Could you please add this change to the CHANGELOG?

@koral--
Copy link
Contributor Author

koral-- commented Mar 28, 2017

I'm not sure who should update a CHANGELOG and whether version number is correct (I've used date of merge). If PR authors should do it, there should be such information in REDAME perhaps.

BTW it seems that tag for this change is also missing and there is no release for current latest tag: https://github.com/bitrise-docker/android-ndk/releases

@viktorbenei
Copy link
Contributor

Ohh, you're right @koral-- we forgot to tag it here; I'll do that ASAP!

it's less important to mark releases here for our docker images as the tags on docker hub are completely separate ones, mainly because we do scheduled builds (alphas are rebuilt every day, pinned ones once a week when every test passes on the specified alpha).

But in any case I'll do the README and tag update ASAP, thanks for the reminder!

@viktorbenei
Copy link
Contributor

Done, CHANGELOG merged from #49 and tag added to the repo too - thanks again @koral-- for all the contribution, and thanks @jfirebaugh for the reminder!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants