Return empty array instead of an error #218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are valid cases when a project does not contain any accessible schemes. One such case is if you generate a new Cocoapods project with a newer Cocoapods version. So it is fine to return an empty array instead of throwing an error.
Later in the code path we already had a validation to make sure we have a scheme with the given name:
go-xcode/xcodeproject/xcworkspace/schemes.go
Lines 82 to 98 in e6be8ef