Skip to content
This repository has been archived by the owner on May 3, 2023. It is now read-only.

Clarify build id getter test cases #47

Merged
merged 1 commit into from Dec 13, 2021
Merged

Conversation

gaborszakacs
Copy link
Contributor

External build ids should always be unique, this adds more confidence in the tests (as we're sure it finds the build id in stage3 too).

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a MAJOR/MINOR/PATCH version update

Context

Changes

Investigation details

Decisions

Copy link

@sylank sylank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sylank sylank merged commit 8360f28 into main Dec 13, 2021
@sylank sylank deleted the clarify-build-id-getter-tests branch December 13, 2021 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants