Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RA-1191] Create step #1

Merged
merged 5 commits into from Jul 6, 2023
Merged

[RA-1191] Create step #1

merged 5 commits into from Jul 6, 2023

Conversation

tothszabi
Copy link
Contributor

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a MAJOR version update

Context

This is the first version of the step. It is very simple and at the moment does not do much. It just calls an endpoint with the user provided values which will schedule a new release in the Bitrise release management. It also exports some values from the response so the users can use them in their workflow.

The only endpoint this step uses is this one:
https://api-docs.bitrise.io/#/releases/release-create-app-store

Changes

  • The step follows the ideal step architecture
  • The networking is implemented in the client.go file
  • The step does not have any e2e test at the moment because I do not see any way I could a meaningful one
  • The step will have two outputs but at the moment only one of them implemented in the backend so the other value is commented out and left in the PR as a placeholder

@tothszabi tothszabi force-pushed the create-step branch 3 times, most recently from eb287d1 to 587c5b6 Compare June 15, 2023 09:28
api/client.go Outdated Show resolved Hide resolved
api/client.go Outdated Show resolved Hide resolved
api/client.go Outdated Show resolved Hide resolved
api/client.go Outdated Show resolved Hide resolved
export/export.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
step.yml Show resolved Hide resolved
step.yml Outdated Show resolved Hide resolved
step.yml Show resolved Hide resolved
step/step.go Outdated Show resolved Hide resolved
step.yml Outdated Show resolved Hide resolved
@tothszabi tothszabi merged commit 54f8d89 into main Jul 6, 2023
1 check passed
@tothszabi tothszabi deleted the create-step branch July 6, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants