Use shared cache implementation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
commented
Sep 21, 2022
| @@ -171,7 +154,7 @@ workflows: | |||
| --data "client_id=abcs-steps" \ | |||
| --data "client_secret=$CACHE_API_CLIENT_SECRET" \ | |||
| --data "grant_type=urn:ietf:params:oauth:grant-type:uma-ticket" \ | |||
| --data "claim_token=eyJhcHBfaWQiOlsic3RlcC1yZXN0b3JlLWNhY2hlLWUyZS10ZXN0cyJdLCAiaXNfY3JlZGl0X2Jhc2VkIjpbInRydWUiXSwgImlzX3ByaXZhdGVfY2xvdWQiOlsidHJ1ZSJdfQ==" \ | |||
| --data "claim_token=eyJhcHBfaWQiOlsic3RlcC1zYXZlLWNhY2hlLWUyZS10ZXN0cyJdLCAiYWNjZXNzX2dyYW50ZWQiOlsidHJ1ZSJdfQ==" \ | |||
There was a problem hiding this comment.
This is an unrelated change, but a backend-side change broke E2E tests. The base64 encoded claim token need to have different fields now.
imrekel
reviewed
Sep 22, 2022
| @@ -32,14 +40,14 @@ func Upload(params UploadParams, logger log.Logger) error { | |||
| } | |||
| logger.Debugf("Upload ID: %s", resp.ID) | |||
|
|
|||
| logger.Println() | |||
| logger.Debugf("") | |||
There was a problem hiding this comment.
Yes, because debug-level logs are only printed if the verbose input is set to true. We don't want to always log an empty line, just when debug logging is turned on
imrekel
reviewed
Sep 22, 2022
| return "", fmt.Errorf("commas are not allowed in key") | ||
| } | ||
|
|
||
| if len(key) > maxKeyLength { |
There was a problem hiding this comment.
Don't we want to log this to the console when the key is truncated?
There was a problem hiding this comment.
Good idea, I'll create a follow-up PR in go-steputils
imrekel
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
Using shared cache implementation from
go-steputils. There is no functionality change in this PR.Changes
Remove code that had been moved to
go-steputilsand call that code instead.Investigation details
Decisions