Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customized api #13

Merged
merged 6 commits into from Oct 3, 2023
Merged

Conversation

AndyJenness
Copy link
Contributor

@AndyJenness AndyJenness commented Feb 23, 2023

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a MINOR version update
Unsure, either Minor or Patch. It adds some new functionality but is backwards compatabile.

Context

Appetize.io allows for custom api endpoints, e.g. @YourBusinessName.appetize.io/v1/apps. This patch allows for the endpoint and app host name to be customized but defaults to appetize.io to not effect current users of this step.

Changes

  • Added appetize_api, default = @api.appetize.io/v1/apps, to bitrise.yml options with descriptions & defaults
  • Added appetize_host, default = appetize.io, to bitrise.yml options with descriptions & defaults
  • Removed theapiEndPoint constant in client.go
  • Added apiEndPoint as a variable to be passed to NewClient & baseURL in client.go
  • Added host as a variable to be passed to generateAppURL in main.go
  • Updated tests with new variables

Testing

I tested in my bitrise setup using the git url for this fork and was successful for both use cases of defaults and setting new parameters.

Investigation details

Decisions

@AndyJenness
Copy link
Contributor Author

@ofalvai , hi there, I'm trying to get this PR reviewed but it doesn't look like I can assign a reviewer. Would you be able to assist? Thank you!

@AndyJenness
Copy link
Contributor Author

@BirmacherAkos , I see that you've reviewed for this repo before, do you mind taking a look at this PR?

@vshah23
Copy link

vshah23 commented May 2, 2023

Hi @AndyJenness we appreciate your contribution to improving this step!

Copy link

@vshah23 vshah23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run gofmt in the project directory.

@AndyJenness
Copy link
Contributor Author

AndyJenness commented Jun 26, 2023

@vshah23 Thanks for reviewing! Sorry, I missed your comment for so long. I've run gofmt and updated the files.

@lpusok lpusok merged commit 8364b2f into bitrise-steplib:master Oct 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants