New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customized api #13
Customized api #13
Conversation
@ofalvai , hi there, I'm trying to get this PR reviewed but it doesn't look like I can assign a reviewer. Would you be able to assist? Thank you! |
@BirmacherAkos , I see that you've reviewed for this repo before, do you mind taking a look at this PR? |
Hi @AndyJenness we appreciate your contribution to improving this step! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run gofmt
in the project directory.
@vshah23 Thanks for reviewing! Sorry, I missed your comment for so long. I've run |
Checklist
step.yml
andREADME.md
is updated with the changes (if needed)Version
Requires a MINOR version update
Unsure, either Minor or Patch. It adds some new functionality but is backwards compatabile.
Context
Appetize.io
allows for custom api endpoints, e.g.@YourBusinessName.appetize.io/v1/apps
. This patch allows for the endpoint and app host name to be customized but defaults toappetize.io
to not effect current users of this step.Changes
appetize_api
, default =@api.appetize.io/v1/apps
, tobitrise.yml
options with descriptions & defaultsappetize_host
, default =appetize.io
, tobitrise.yml
options with descriptions & defaultsapiEndPoint
constant inclient.go
apiEndPoint
as a variable to be passed toNewClient
&baseURL
inclient.go
host
as a variable to be passed togenerateAppURL
inmain.go
Testing
I tested in my bitrise setup using the git url for this fork and was successful for both use cases of defaults and setting new parameters.
Investigation details
Decisions